-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove session preferences on logout. #2303
Remove session preferences on logout. #2303
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2303 +/- ##
===========================================
- Coverage 70.05% 70.04% -0.02%
===========================================
Files 1353 1353
Lines 33233 33239 +6
Branches 6872 6873 +1
===========================================
Hits 23283 23283
- Misses 6641 6647 +6
Partials 3309 3309 ☔ View full report in Codecov by Sentry. |
Observe the sessions in `DefaultSessionPreferencesFactory` and remove the session preferences from both the cache and disk when a session is finished.
5edb4bc
to
8e9e9d8
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Type of change
Content
DefaultSessionPreferencesStoreFactory
and both remove the preferences from its cache and from disk when a user is logged out.Motivation and context
We should remove session preferences when the user logs out.
Tests
Tested devices
Checklist