-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send typing notification #2302
Send typing notification #2302
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, and I'm glad you found the onTyping
API of the RTE!
There's only one thing that bothers me, the Rust SDK doesn't seem to be sending a 'no longer typing' message to the server when we set call typingNotice(false)
. If I set up the debugger I can see the false
value arriving and being sent to the Rust SDK, but when I look at the other client I can still see the typing...
status until the 4s timeout happens.
It's not something we can fix in this PR, so we should merge it as is, but I think we should also investigate what's wrong with the SDK behaviour.
matrix-org/matrix-rust-sdk#3064 has been created to track the observed issue. |
Actually I think it's a feature of Element Web; see matrix-org/matrix-rust-sdk#3064 (comment) If you use another client, for instance Element Android, the typing notification disappears faster when the other user stops typing. |
Type of change
Content
Send typing notification.
Note: there will be a setting to disable typing notification, it's tracked by #2241.
Motivation and context
Closes #2240
Screenshots / GIFs
NA
Tests
Tested devices
Checklist