Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate on notification badges #2293

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 25, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure that the green dot does not appear on regular message if there is no mention in the new message and the global notification setting is set to mention only.

Basically uses the data provided by the SDK and mimic the iOS logic.

Motivation and context

Closes #2282

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner January 25, 2024 15:38
@bmarty bmarty requested review from ganfra and removed request for a team January 25, 2024 15:38
Copy link
Contributor

github-actions bot commented Jan 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RVTKHy

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (203262a) 70.03% compared to head (c5fc45e) 70.01%.
Report is 32 commits behind head on develop.

Files Patch % Lines
...eatures/roomlist/impl/components/RoomSummaryRow.kt 80.64% 1 Missing and 5 partials ⚠️
...eatures/roomlist/impl/model/RoomListRoomSummary.kt 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2293      +/-   ##
===========================================
- Coverage    70.03%   70.01%   -0.02%     
===========================================
  Files         1351     1351              
  Lines        33137    33132       -5     
  Branches      6866     6867       +1     
===========================================
- Hits         23207    23199       -8     
  Misses        6623     6623              
- Partials      3307     3310       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 30, 2024
@bmarty bmarty enabled auto-merge January 30, 2024 09:13
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 30, 2024
@bmarty bmarty merged commit a7541be into develop Jan 30, 2024
17 of 18 checks passed
@bmarty bmarty deleted the feature/bma/notificationCount branch January 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Green 'new unread' icon displayed in timeline for account with 'only mentions and keywords' enabled
2 participants