-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterate on notification badges #2293
Conversation
Implement the iOS logic #2282
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2293 +/- ##
===========================================
- Coverage 70.03% 70.01% -0.02%
===========================================
Files 1351 1351
Lines 33137 33132 -5
Branches 6866 6867 +1
===========================================
- Hits 23207 23199 -8
Misses 6623 6623
- Partials 3307 3310 +3 ☔ View full report in Codecov by Sentry. |
Type of change
Content
Ensure that the green dot does not appear on regular message if there is no mention in the new message and the global notification setting is set to mention only.
Basically uses the data provided by the SDK and mimic the iOS logic.
Motivation and context
Closes #2282
Screenshots / GIFs
Tests
Tested devices
Checklist