Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git sha and branch in log #2292

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Git sha and branch in log #2292

merged 6 commits into from
Jan 25, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 25, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Give more information on logs (and so in rageshake data) regarding the source used to build the app, as we did on EA.

Motivation and context

Ease investigation when looking at rageshake logs, and add a quick information on the branch in the root preference screen, when not built form the main branch.

Screenshots / GIFs

Tests

NA

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner January 25, 2024 13:39
@bmarty bmarty requested review from jmartinesp and removed request for a team January 25, 2024 13:39
Copy link
Contributor

github-actions bot commented Jan 25, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/L8rgrV

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (99683d4) 70.15% compared to head (6933eb5) 70.17%.
Report is 11 commits behind head on develop.

Files Patch % Lines
.../src/main/kotlin/io/element/android/x/info/Logs.kt 0.00% 3 Missing ⚠️
...c/main/kotlin/io/element/android/x/di/AppModule.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2292      +/-   ##
===========================================
+ Coverage    70.15%   70.17%   +0.02%     
===========================================
  Files         1335     1335              
  Lines        32802    32804       +2     
  Branches      6809     6810       +1     
===========================================
+ Hits         23012    23020       +8     
+ Misses        6511     6505       -6     
  Partials      3279     3279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 25, 2024
@bmarty bmarty enabled auto-merge January 25, 2024 16:20
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 25, 2024
@bmarty bmarty merged commit f88d96f into develop Jan 25, 2024
17 of 18 checks passed
@bmarty bmarty deleted the feature/bma/gitSha branch January 25, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants