Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited text message bubbles should resize when edited #2272

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jan 22, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Makes ContentAvoidingLayoutScopeInstance stable and state-aware, so it can be used by ContentAvoidingLayout to re-layout when its data changes.
  • The change above makes it possible to use Layout instead of SubcomposeLayout for the layout process, which should improve performance.

Motivation and context

Fixes #2060

Screenshots / GIFs

Screen_recording_20240122_111123.mp4

Tests

  • In a room, edit a message so it overlaps the timestamp. Once edited, the message bubble should resize and avoid the overlapping.
  • Edit it back so it doesn't overlap anymore. The message bubble should resize again.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner January 22, 2024 10:16
@jmartinesp jmartinesp requested review from bmarty and removed request for a team January 22, 2024 10:16
Copy link
Contributor

github-actions bot commented Jan 22, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JaHUSV

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3538e5) 70.04% compared to head (8d376fb) 70.04%.
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2272   +/-   ##
========================================
  Coverage    70.04%   70.04%           
========================================
  Files         1335     1335           
  Lines        32674    32674           
  Branches      6792     6791    -1     
========================================
+ Hits         22885    22886    +1     
  Misses        6512     6512           
+ Partials      3277     3276    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member Author

With this change, it should be possible to move back to using Layout instead of SubcomposeLayout, which should be more efficient. So far I haven't encountered #2155 in release mode, but I'll keep testing it a bit.

@jmartinesp jmartinesp force-pushed the fix/jme/2260-edited-message-bubble-wont-resize branch from f7c0d42 to 8d376fb Compare January 22, 2024 11:06
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I cannot repro the original issue... This is not blocking the merge of this PR.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 22, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 22, 2024
@jmartinesp jmartinesp merged commit 18fba26 into develop Jan 22, 2024
18 checks passed
@jmartinesp jmartinesp deleted the fix/jme/2260-edited-message-bubble-wont-resize branch January 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edited bubble broken
2 participants