Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Strings #2271

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Sync Strings #2271

merged 1 commit into from
Jan 22, 2024

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner January 22, 2024 00:10
@ElementBot ElementBot requested review from ganfra and removed request for a team January 22, 2024 00:10
@ElementBot
Copy link
Collaborator Author

ElementBot commented Jan 22, 2024 •
edited
Loading

Warnings
⚠️

features/roomdetails/impl/src/main/res/values-cs/translations.xml#L3 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

features/roomdetails/impl/src/main/res/values-sk/translations.xml#L3 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L216 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L221 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L226 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-cs/translations.xml#L231 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L216 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L221 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L226 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️

libraries/ui-strings/src/main/res/values-sk/translations.xml#L231 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 4914c51

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/P1HAiH

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb822a5) 69.98% compared to head (4914c51) 69.98%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2271   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1335     1335           
  Lines        32680    32680           
  Branches      6791     6791           
========================================
  Hits         22870    22870           
  Misses        6534     6534           
  Partials      3276     3276

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty reviewed Jan 22, 2024
View reviewed changes
features/messages/impl/src/main/res/values-fr/translations.xml
@@ -23,7 +23,7 @@
<string name="screen_room_attachment_source_camera_photo">"Prendre une photo"</string>
<string name="screen_room_attachment_source_camera_video">"Enregistrer une vidéo"</string>
<string name="screen_room_attachment_source_files">"Pièce jointe"</string>
<string name="screen_room_attachment_source_gallery">"Gallerie Photo et Vidéo"</string>
<string name="screen_room_attachment_source_gallery">"Galerie Photo et Vidéo"</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnjbvr 👋

bmarty
bmarty approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@bmarty bmarty merged commit f13eef9 into develop Jan 22, 2024
16 checks passed
@bmarty bmarty deleted the sync-localazy branch January 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra Awaiting requested review from ganfra ganfra is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElementBot @bmarty