Update plugin ktlint to v12.1.0 #2200
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
the
PR-Dependencies
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
|
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
| if (!applyPaddingToContents) { | ||
| then(Modifier.padding(DialogContentDefaults.externalHorizontalPadding)) | ||
| } | ||
| } |
There was a problem hiding this comment.
This does not seem to be equivalent, see the failure in the screenshot test:
There was a problem hiding this comment.
Yes, I restored the previous behaviour here: b3ba069
I guess the .apply lambda captures the initial value of applyPaddingToContents and never updates it.
There was a problem hiding this comment.
The other change is because the changed material.Text to material3.Text and the rendering is slightly different.
There was a problem hiding this comment.
Actually the returned value of apply is its receiver. This is not the case for then, which return other in this case.
// Align the title to the center when an icon is present.
(
if (applyPaddingToContents)
Modifier
else
Modifier.padding(DialogContentDefaults.externalHorizontalPadding)
)
.padding(DialogContentDefaults.titlePadding)
.align(
if (icon == null) {
Alignment.Start
} else {
Alignment.CenterHorizontally
}
)would have worked too (I think), hence a bit hard to read.
There was a problem hiding this comment.
Oh, true 🤦 . Maybe a .run { ... } would have worked, but it would look quite weird there.
|
There was a problem hiding this comment.
Thanks, approving all the changes, but I let @jmartinesp merge when ready. Do not wait to much to avoid to handle conflict, regarding the number of impacted files :)
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
This PR contains the following updates:
12.0.3->12.1.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.