Use eventSink method reference in TimelinePresenter.kt #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has been changed in #1172 but in general method references should always preferred to lambdas in composable functions (because they have higher stability guarantees).
|
@jonnyandrew FYI |
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
ganfra
approved these changes
Sep 25, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1428 +/- ##
========================================
Coverage 58.06% 58.06%
========================================
Files 1129 1129
Lines 29880 29880
Branches 6067 6067
========================================
Hits 17351 17351
Misses 9931 9931
Partials 2598 2598
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been changed in #1172 but in general method references should always be preferred to lambdas in composable functions (because they have higher stability guarantees).