Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libolm removal #7852

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Libolm removal #7852

merged 7 commits into from
Oct 15, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 27, 2024

No description provided.

@Velin92
Copy link
Member Author

Velin92 commented Oct 9, 2024 •
edited
Loading

@BillCarsonFr what about these tests?
They seem to fail because the crypto value of the mocked session seems to be always nil

UserSessionCardViewDataTests.testCurrentDeviceWithCrossSigning()
UserSessionCardViewDataTests.testCurrentDeviceWithoutCrossSigning()
UserSessionCardViewDataTests.testOtherSessionsWithCrossSigning

@Velin92 Velin92 marked this pull request as ready for review October 15, 2024 13:35
pixlwave
pixlwave approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Riot/Modules/Authentication/AuthenticationCoordinator.swift Show resolved Hide resolved
Riot/Modules/Authentication/Legacy/Views/AuthInputsView.m Show resolved Hide resolved
@Velin92 Velin92 merged commit 7da255a into develop Oct 15, 2024
4 of 5 checks passed
@Velin92 Velin92 deleted the mauroromito/libolm_deprecated_removal branch October 15, 2024 14:13
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@pixlwave pixlwave pixlwave approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Velin92 @stefanceriu @pixlwave @BillCarsonFr