Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240717 #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

20240717 #19

wants to merge 5 commits into from

Conversation

long568
Copy link

@long568 long568 commented Jul 16, 2024

Add
set_4chs_on_off
set_8chs_on_off
set_12chs_on_off
to improve efficiency

@coveralls
Copy link

coveralls commented Jul 16, 2024

Coverage Status

coverage: 91.139% (-6.4%) from 97.517%
when pulling 3b47052 on long568:master
into a4c34eb on eldruin:master.

@eldruin
Copy link
Owner

eldruin commented Jul 16, 2024

Thank you for the idea. In order to avoid code duplication I have reimplemented this using const generics and a macro.
Please see the current master branch status.
I have not derived PartialOrd and Ord for Channel because of the All variant, since that does not seem comparable to the rest.
Is the current state adequate for you?

@long568
Copy link
Author

long568 commented Jul 17, 2024

yes,it's adequate for me.
i added set_2chs_on_off also.
thx

@long568
Copy link
Author

long568 commented Jul 17, 2024

Macro is great idea.

@long568
Copy link
Author

long568 commented Jul 18, 2024

Hi, I need to set a batch of channels from an arbitrary starting position, so I submitted a new merge request.

@eldruin
Copy link
Owner

eldruin commented Jul 22, 2024

Interesting idea, thanks. I will look into adapting it to the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants