Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sync code to the blocking module in prep for #13 #14

Closed
wants to merge 1 commit into from
Closed

Move sync code to the blocking module in prep for #13 #14

wants to merge 1 commit into from

Conversation

nils-van-zuijlen
Copy link
Contributor

Move sync code that interacts with the I2C to a separate module, in preparation for adding an async module.

Half of the work for #13

eldruin
eldruin reviewed Jan 19, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could you fix the formatting?
Other than that this looks good to me.

@eldruin
Copy link
Owner

eldruin commented Jan 19, 2024

I have fixed the CI now, could you rebase this?

@nils-van-zuijlen @eldruin
Move sync code to the blocking module
195be3c 
Move sync code that interacts with the I2C to a separate module,
in preparation for adding an async module.
@coveralls
Copy link

Coverage Status

coverage: 90.661%. remained the same
when pulling 195be3c on nils-van-zuijlen:async-split
into a6fb6f7 on eldruin:master.

@nils-van-zuijlen nils-van-zuijlen mentioned this pull request Feb 1, 2024
Merged
@nils-van-zuijlen nils-van-zuijlen deleted the async-split branch February 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nils-van-zuijlen @eldruin @coveralls