Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: cert-manager networkpolicies with generator #1938

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

aarnq
Copy link
Contributor

@aarnq aarnq commented Dec 21, 2023

Warning

This is public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request
  • business confidential information, such as customer names

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Use networkpolicy generator for cert-manager.

Additional information to reviewers

Screenshots

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packages in the NetworkPolicy Dashboard
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Bug checks:
    • The bug fix is covered by regression tests

@aarnq aarnq added app/cert-manager cert-manager - Certificate Management kind/cleanup An issue which does not add value today, but makes it easier to add value tomorrow. labels Dec 21, 2023
@aarnq aarnq self-assigned this Dec 21, 2023
@aarnq aarnq force-pushed the aarnq/use-reworked-helmfile branch 3 times, most recently from 51d9fcd to b8006f7 Compare December 22, 2023 14:13
Base automatically changed from aarnq/use-reworked-helmfile to main December 22, 2023 14:16
@aarnq aarnq force-pushed the aarnq/cert-manager-netpol-gen branch from da07526 to 692384b Compare January 8, 2024 09:51
@aarnq aarnq force-pushed the aarnq/cert-manager-netpol-gen branch from 692384b to b2b09d0 Compare January 11, 2024 07:18
@aarnq aarnq merged commit b2b09d0 into main Jan 11, 2024
9 checks passed
@aarnq aarnq deleted the aarnq/cert-manager-netpol-gen branch January 11, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/cert-manager cert-manager - Certificate Management kind/cleanup An issue which does not add value today, but makes it easier to add value tomorrow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants