apps: upgrade falco chart and rework exceptions #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliastisys
requested review from
Pavan-Gunda,
viktor-f and
raviranjanelastisys
Eliastisys
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
5dc8cd3
to
afb76b7
Compare
viktor-f
reviewed
Oct 27, 2023
LundqvistAndre
force-pushed
the
andre-elias/upgrade-falco-chart
branch
3 times, most recently
from
83b8c24
to
0957947
Compare
Remove old irrelevant rule/exceptions not applicable for old falco version. Add/keep relevant rules for the new falco version.
LundqvistAndre
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
0957947
to
5c253a5
Compare
viktor-f
reviewed
Oct 30, 2023
Only default rules are used. Noted in PR message. @viktor-f |
LundqvistAndre
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
28af8b5
to
1b2702d
Compare
viktor-f
reviewed
Oct 31, 2023
Enable upstream sandbox and incubating rules. Add the option to enable/disable/tag upstream rule files in common-config. Additonally add exceptions for the most spammy rules from the upstream rule files.
LundqvistAndre
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
1b2702d
to
83a1927
Compare
viktor-f
reviewed
Oct 31, 2023
|
You should add the release note or admin change in the PR description instead (there are some headers that you can uncomment from the template) and you can remove the text in the wip-changelog (that files is deprecated). |
Eliastisys
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
82da963
to
bc0c151
Compare
@viktor-f Does it look ok now? |
viktor-f
approved these changes
Nov 3, 2023
Eliastisys
changed the title
Pavan-Gunda
approved these changes
Nov 6, 2023
During prolonged running, more alerts were observed. Add exceptions for the observed alerts
LundqvistAndre
force-pushed
the
andre-elias/upgrade-falco-chart
branch
from
09ddad8
to
1b374ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityWhat does this PR do / why do we need this PR?
Which issue this PR fixes: fixes #1807
Upgrades falcosecurity/falco to 3.8.3 with app version 0.36.1.
Upgrades falcosecurity/falco-exporter to 0.9.7.
Adds an option to enable/disable upstream rule files in apps config.
Tests falco on compliant with all AMS installed.
Filters out false positives with exceptions while default, sandbox and incubating rules are enabled.
Platform Administrator notice
Checklist
Note!
New issues should be created to add more rules back into our platform before this is merged.