Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: e2e for Grafana, Opensearch and Harbor #1775

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

crssnd
Copy link
Contributor

@crssnd crssnd commented Sep 14, 2023

Warning

This is public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request
  • business confidential information, such as customer names

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

  • the e2e tests

Additional information to reviewers

Screenshots

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packages in the NetworkPolicy Dashboard
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy

@crssnd crssnd changed the base branch from main to aarnq/new-test-harness September 14, 2023 08:43
@crssnd crssnd requested a review from aarnq September 14, 2023 08:43
@aarnq aarnq force-pushed the aarnq/new-test-harness branch 5 times, most recently from f18a008 to 3d0e896 Compare September 15, 2023 12:34
@crssnd crssnd force-pushed the crssnd/e2e-grafana-dashboards-tests branch from cfa9b4f to c4cab85 Compare September 15, 2023 13:02
@crssnd crssnd marked this pull request as ready for review September 15, 2023 13:35
@crssnd crssnd force-pushed the crssnd/e2e-grafana-dashboards-tests branch from c4cab85 to e1d7957 Compare September 15, 2023 14:31
@crssnd crssnd force-pushed the crssnd/e2e-grafana-dashboards-tests branch 4 times, most recently from 865ab20 to 97381cb Compare October 17, 2023 12:44
@crssnd crssnd changed the base branch from aarnq/new-test-harness to main October 20, 2023 10:55
@crssnd crssnd changed the base branch from main to aarnq/new-test-harness October 20, 2023 10:55
Base automatically changed from aarnq/new-test-harness to main October 23, 2023 07:57
@crssnd crssnd force-pushed the crssnd/e2e-grafana-dashboards-tests branch from 97381cb to ac893b5 Compare October 24, 2023 11:35
@crssnd crssnd changed the base branch from main to QA-0.13 October 24, 2023 11:36
@crssnd crssnd changed the base branch from QA-0.13 to main October 24, 2023 11:36
@crssnd crssnd force-pushed the crssnd/e2e-grafana-dashboards-tests branch 2 times, most recently from 33ea35c to e3bc483 Compare October 24, 2023 11:41
@crssnd
Copy link
Contributor Author

crssnd commented Oct 24, 2023

let me know if you prefer a demo to better understand this tests

Copy link
Contributor

@robinAwallace robinAwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say a demo is a good idea for this PR 🙂

tests/end-to-end/opensearch-static-dex-user.cy.js Outdated Show resolved Hide resolved
@crssnd crssnd changed the title Crssnd/e2e grafana dashboards tests tests: e2e for Grafana, Opensearch and Harbor Oct 24, 2023
Copy link
Contributor

@Xartos Xartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one minor thing

tests/common/grafana.js Outdated Show resolved Hide resolved
@crssnd
Copy link
Contributor Author

crssnd commented Oct 30, 2023

I think I manage to fix all the comments:

  • clean-up in habor after the project and robot account wee created
  • dropped the sessions validation for fix sessions being re-created even if it already exists
  • clear all session data at the end of each test

tests/cypress.support.js Outdated Show resolved Hide resolved
tests/cypress.support.js Outdated Show resolved Hide resolved
tests/cypress.support.js Outdated Show resolved Hide resolved
@aarnq aarnq force-pushed the crssnd/e2e-grafana-dashboards-tests branch from da71906 to 68b21b3 Compare November 10, 2023 15:38
@aarnq aarnq force-pushed the crssnd/e2e-grafana-dashboards-tests branch 3 times, most recently from d38c553 to 67cfb3e Compare November 20, 2023 10:59
@aarnq aarnq self-assigned this Nov 20, 2023
crssnd and others added 2 commits November 22, 2023 08:22
@aarnq aarnq force-pushed the crssnd/e2e-grafana-dashboards-tests branch from 67cfb3e to aa2cd08 Compare November 22, 2023 07:23
@aarnq aarnq merged commit aa2cd08 into main Nov 22, 2023
15 checks passed
@aarnq aarnq deleted the crssnd/e2e-grafana-dashboards-tests branch November 22, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants