-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: e2e for Grafana, Opensearch and Harbor #1775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnq
force-pushed
the
aarnq/new-test-harness
branch
5 times, most recently
from
September 15, 2023 12:34
f18a008
to
3d0e896
Compare
crssnd
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
from
September 15, 2023 13:02
cfa9b4f
to
c4cab85
Compare
crssnd
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
from
September 15, 2023 14:31
c4cab85
to
e1d7957
Compare
aarnq
force-pushed
the
aarnq/new-test-harness
branch
from
October 4, 2023 14:50
3d0e896
to
9c3c903
Compare
crssnd
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
4 times, most recently
from
October 17, 2023 12:44
865ab20
to
97381cb
Compare
aarnq
force-pushed
the
aarnq/new-test-harness
branch
from
October 23, 2023 07:52
c52de8e
to
873e32f
Compare
crssnd
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
from
October 24, 2023 11:35
97381cb
to
ac893b5
Compare
crssnd
requested review from
pettersv,
viktor-f,
Xartos,
simonklb and
OlleLarsson
as code owners
October 24, 2023 11:36
crssnd
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
2 times, most recently
from
October 24, 2023 11:41
33ea35c
to
e3bc483
Compare
let me know if you prefer a demo to better understand this tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say a demo is a good idea for this PR 🙂
crssnd
changed the title
Crssnd/e2e grafana dashboards tests
tests: e2e for Grafana, Opensearch and Harbor
Oct 24, 2023
Xartos
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one minor thing
I think I manage to fix all the comments:
|
Xartos
approved these changes
Nov 1, 2023
aarnq
reviewed
Nov 7, 2023
aarnq
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
from
November 10, 2023 15:38
da71906
to
68b21b3
Compare
aarnq
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
3 times, most recently
from
November 20, 2023 10:59
d38c553
to
67cfb3e
Compare
OlleLarsson
approved these changes
Nov 20, 2023
Updates the Gatekeeper and NIGNX dashboards
aarnq
force-pushed
the
crssnd/e2e-grafana-dashboards-tests
branch
from
November 22, 2023 07:23
67cfb3e
to
aa2cd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
Additional information to reviewers
Screenshots
Checklist
NetworkPolicy Dashboard