Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add history_window_start and new_terms_fields editable fields #200304

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nikitaindik
Copy link
Contributor

@nikitaindik nikitaindik commented Nov 15, 2024

Partially addresses: #171520

Summary

Changes in this PR:

  • history_window_start and new_terms_fields are now editable in the Rule Upgrade flyout
  • Extracted fields into separate components that are easier to reuse (NewTermsFieldsEdit and HistoryWindowStartEdit)
Scherm­afbeelding 2024-11-15 om 15 51 04

Testing

  • Ensure the prebuiltRulesCustomizationEnabled feature flag is enabled.
  • To simulate the availability of prebuilt rule upgrades, downgrade a currently installed prebuilt rule using the PATCH api/detection_engine/rules API.
    • Set version: 1 in the request body to downgrade it to version 1.
    • Modify other rule fields in the request body as needed to test the changes.

@nikitaindik nikitaindik added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 15, 2024
@nikitaindik nikitaindik self-assigned this Nov 15, 2024
@nikitaindik nikitaindik marked this pull request as ready for review November 15, 2024 14:54
@nikitaindik nikitaindik requested review from a team as code owners November 15, 2024 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik requested review from maximpn and removed request for dplumlee November 15, 2024 14:55
@banderror banderror added v9.0.0 backport:version Backport to applied version labels v8.17.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 15, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #57 / Screenshots - serverless security UI response ops docs security cases security case settings case settings screenshot
  • [job] [logs] FTR Configs #87 / Visualizations - Group 3 lens app - TSVB Open in Lens Table should convert color ranges

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6202 6213 +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB +1.4KB

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants