-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Update alert kpi to exclude closed alerts in document details flyout #200268
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for bringing the consistent behavior between the entity and the alerts details flyout. Desk tested and code LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why there are changes to this file? I see that these were introduced by an auto CI commit... weird...
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
Summary
This PR made some changes to the alert count API in document details flyout. Closed alerts are now removed when showing total count and distributions. Data fetching logic is updated to match the one used in host flyout (#197102).
Notable changes:
NOT kibana.alert.workflow_status: closed
filtersScreen.Recording.2024-11-14.at.4.05.08.PM.mov
Checklist