chore: instrument smithy-client v2

[david-luna]

Add support for @smithy/smithy-client v2+. This version is introduced by @aws-sdk/client-s3 and others in version v3.378.0

Looking at the major release of smithy-client there are breaking changes in its types but these are not affecting the middlewares of the AWS clients so its safe to add support for it.

Closes #3523

Checklist

• Implement code
• Add tests
• Update TypeScript typings
• Update documentation
• Add CHANGELOG.asciidoc entry
• Commit message follows commit guidelines

[david-luna]

Note to reviewer: moved the smithy client file so path represents properly the namespace of the package on its recent version

[david-luna]

/test tav @aws-sdk/client-s3

[david-luna]

/test tav @aws-sdk/client-s3 16

[trentm]

Need to fix the package-lock file.

[trentm]

This accidentally changed to lockfileVersion: 1:

diff --git a/package-lock.json b/package-lock.json
index 51f534bf..bc50cde7 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,17985 +1,8 @@
 {
   "name": "elastic-apm-node",
   "version": "3.48.0",
-  "lockfileVersion": 2,
+  "lockfileVersion": 1,
...

I think you may have npm installed with an older version of Node than v16.

[trentm]

The huge change to package-lock.json here is partly due to the git diff algorithm. It is more sane with the "patience" algorithm:

% git diff main...  | wc -l
   35913

% git diff --patience main...  | wc -l
    7261

A lot of the diff is because these devDeps are at different versions:

    "@aws-sdk/client-s3": "^3.379.1",
    "@aws-sdk/s3-request-presigner": "^3.363.0",

Leading to a loss of a lot of possible dedupes for common transitive deps -- now at different versions. I'll upgrade the latter and see if that helps.

[trentm]

Yes, that helps a lot. For example, instead of >30 installations of @smithy/types, there is now just one:

% npm ls @smithy/types | rg -v deduped | rg smithy/types
│ ├── @smithy/[email protected]

And the diff is reduced:

% git diff --patience main...  | wc -l
    3648

and with the default algorithm as well:

% git diff  main...  | wc -l
    3660

@david-luna I think as a rule, if we update one @aws-sdk/... dep, we should update them all.

[trentm]

LGTM, assuming tests pass again.

[trentm]

/test tav @aws-sdk/client-s3