Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include http apm client #3507

Merged
merged 16 commits into from
Jul 29, 2023
Merged

chore: include http apm client #3507

merged 16 commits into from
Jul 29, 2023

Conversation

david-luna
Copy link
Member

@david-luna david-luna commented Jul 25, 2023

Adding source code from https://github.com/elastic/apm-nodejs-http-client into the apm-client module. Summary of the changes:

  • moved client config resolution next to createApmClient method
  • add client code into http-apm-client.js and name the export to HttpApmClient
  • put the lib files (truncate, ndjson, ...) next to the client file

Closes #3506

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jul 25, 2023
@trentm trentm marked this pull request as ready for review July 26, 2023 14:30
@trentm trentm self-requested a review July 26, 2023 14:30
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…astic#3507)

This moves the apm-nodejs-http-client.git code into 
"{lib,test}/apm-client/http-apm-client/..." in this repo. This will
help maintenance of multiple active branches of the APM agent.

The only changes are to rename the export to `HttpApmClient` and adjust
require paths. Some functions were moved from lib/apm-client/http-apm-client.js
to lib/apm-client/apm-client.js to clarify.

Closes: elastic#3506
Co-authored-by: Trent Mick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move elastic-apm-http-client into this repository
2 participants