Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix nightly tests to properly skip prerelease node versions >=18 #3033

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Nov 18, 2022

This is a follow-on to #3031 to handle testing of Node.js nightly
builds. These have a prerelease version, e.g.
"v20.0.0-nightly202211186f9175deaa", and therefore need the
includePrelease semver option for gte comparison.

Refs: #3031

This is a follow-on to #3031 to handle testing of Node.js nightly
builds. These have a prerelease version, e.g.
"v20.0.0-nightly202211186f9175deaa", and therefore need the
includePrelease semver option for gte comparison.

Refs: #3031
@trentm trentm self-assigned this Nov 18, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 18, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Nov 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-18T19:35:22.038+0000

  • Duration: 23 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 25600
Skipped 0
Total 25600

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 2b82e37 into main Nov 18, 2022
@trentm trentm deleted the trentm/restify-9-prerelease-check branch November 18, 2022 21:56
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
elastic#3033)

This is a follow-on to elastic#3031 to handle testing of Node.js nightly
builds. These have a prerelease version, e.g.
"v20.0.0-nightly202211186f9175deaa", and therefore need the
includePrelease semver option for gte comparison.

Refs: elastic#3031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants