You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mentioned package is meant to be used only by the nodejs APM agent and having it as a dependency it slows down the time to respond to an issue related to it since:
we need to implement the fix in the package
we need to publish a new version of it
we need to update the dependency in the agent (and maybe update its integration code)
we can finally publish the fixed version
Since a new major release is coming (4.x) the effort will be doubled since we will also keep doing maintenance of 3.x. So for the sake of better maintenance of both versions we should include the sources of the apm-client into the agent. With this approach we will have:
less steps to publish a fix
easier backporting of that fix to 3.x
There is already a module inside the agent named apm-client waiting for the code to be included there.
The text was updated successfully, but these errors were encountered:
)
This moves the apm-nodejs-http-client.git code into
"{lib,test}/apm-client/http-apm-client/..." in this repo. This will
help maintenance of multiple active branches of the APM agent.
The only changes are to rename the export to `HttpApmClient` and adjust
require paths. Some functions were moved from lib/apm-client/http-apm-client.js
to lib/apm-client/apm-client.js to clarify.
Closes: #3506
Co-authored-by: Trent Mick <[email protected]>
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this issue
Aug 20, 2024
…astic#3507)
This moves the apm-nodejs-http-client.git code into
"{lib,test}/apm-client/http-apm-client/..." in this repo. This will
help maintenance of multiple active branches of the APM agent.
The only changes are to rename the export to `HttpApmClient` and adjust
require paths. Some functions were moved from lib/apm-client/http-apm-client.js
to lib/apm-client/apm-client.js to clarify.
Closes: elastic#3506
Co-authored-by: Trent Mick <[email protected]>
The mentioned package is meant to be used only by the nodejs APM agent and having it as a dependency it slows down the time to respond to an issue related to it since:
Since a new major release is coming (4.x) the effort will be doubled since we will also keep doing maintenance of 3.x. So for the sake of better maintenance of both versions we should include the sources of the apm-client into the agent. With this approach we will have:
There is already a module inside the agent named apm-client waiting for the code to be included there.
The text was updated successfully, but these errors were encountered: