Xcframework generation #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the removal of extra libraries in the swift package means the 'ElasticApm' target no longer needs to be seperately distinguished by xcodebuild
bryce-b
force-pushed
the
xcframework-generation
branch
2 times, most recently
from
562986e
to
1c1f574
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
from
1c1f574
to
c8433ef
Compare
refactored config to not use PersistentExporter classes in public APIs
bryce-b
force-pushed
the
xcframework-generation
branch
from
c9cabcb
to
a998e4f
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
10 times, most recently
from
a0f2fb1
to
13e8e31
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
4 times, most recently
from
e052d52
to
cb78116
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
2 times, most recently
from
1fd4bef
to
de9913d
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
from
de9913d
to
52a186d
Compare
Co-authored-by: Victor Martinez <[email protected]>
bryce-b
force-pushed
the
xcframework-generation
branch
11 times, most recently
from
2f6365a
to
124f9c9
Compare
bryce-b
force-pushed
the
xcframework-generation
branch
from
124f9c9
to
8e104ff
Compare
v1v
reviewed
Jun 10, 2024
| --- | ||
| name: xcframework builder | ||
| on: | ||
| workflow_dispatch: |
| tar -czf "./dist/ElasticApm_macOS-${APP_VERSION}.tar.gz" -C ./package ElasticApm_macOS.xcframework | ||
| tar -czf "./dist/ElasticApm_iOS-${APP_VERSION}.tar.gz" -C ./package ElasticApm_iOS.xcframework | ||
| - name: Generate framework provenance | ||
| uses: actions/attest-build-provenance@173725a1209d09b31f9d30a3890cf2757ebbff0d # v1.1.2 |
There was a problem hiding this comment.
Suggested change
| uses: actions/attest-build-provenance@173725a1209d09b31f9d30a3890cf2757ebbff0d # v1.1.2 | |
| uses: actions/attest-build-provenance@49df96e17e918a15956db358890b08e61c704919 # v1.2.0 |
| xcode-version: latest-stable | ||
| - uses: actions/checkout@v4 | ||
| - name: xcodegen | ||
| uses: bryce-b/xcodegen-action@patch-1 |
Comment on lines
+19
to
+28
| - uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0 | ||
| with: | ||
| xcode-version: latest-stable | ||
| - uses: actions/checkout@v4 | ||
| - name: xcodegen | ||
| uses: bryce-b/xcodegen-action@patch-1 | ||
| with: | ||
| spec: project.yml | ||
| quiet: false | ||
| version: '2.41.0' |
There was a problem hiding this comment.
I see this pattern in a few places, do you want me to refactor it using a GitHub composite action? I can contribute to your PR
There was a problem hiding this comment.
@v1v hold of of this for now. I've run into a blocker with the deployed artifact that may prevent this PR from going forward. I'm going to close this PR for now. We can also close https://github.com/elastic/observability-robots/issues/2223.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_implementationOnlyto prevent issues in generating binary artifacts.issues to resolve:
ReadableSpan,ReadableLogRecord, andmetric.