forked from qtile/qtile
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
PangoLayout
error on widget reload
We experience `PangoLayout` errors if widgets try to draw to drawers that have been finalised. This can happen when timers schedule drawing. We deal with this by making sure timers are cancelled when widgets are finalised. However, we only finalise timers that have been created by `self.timeout_add`. Timers set by `qtile.call_soon/later` are not tracked. These method are used to set initial timers for widgets at the end of `_configure` so, if these timers have not yet triggered before the widget is finalised then they will still be triggered. This PR fixes that issue by ensuring that initial timers are also set via `timeout_add` so that they can be cancelled on finalising the widget. Fixes qtile#3869
- Loading branch information
1 parent
3ca4c54
commit ba7efd0
Showing
3 changed files
with
32 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters