repaints for chord and measure charts

eighty4 · Oct 10, 2024 · f9afbc8 · f9afbc8
1 parent 2374c80
commit f9afbc8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.0.9
+
+* ChordChartDisplay and MeasureDisplay repaints when painter params update
+
 ## 0.0.8
 
 * MeasureDisplay without notes skips NotePositioning and renders chart without any notes

diff --git a/lib/display/chord_display.dart b/lib/display/chord_display.dart
@@ -73,5 +73,11 @@ class ChordChartPainter extends CustomPainter {
  }
 
  @override
- bool shouldRepaint(CustomPainter oldDelegate) => false;
+ bool shouldRepaint(ChordChartPainter oldDelegate) =>
+ !identical(chord, oldDelegate.chord) ||
+ !identical(fretSpacing, oldDelegate.fretSpacing) ||
+ !identical(noteRadius, oldDelegate.noteRadius) ||
+ !identical(stringCount, oldDelegate.stringCount) ||
+ !identical(stringSpacing, oldDelegate.stringSpacing) ||
+ !identical(tabContext, oldDelegate.tabContext);
 }
diff --git a/lib/display/grid_painter.dart b/lib/display/grid_painter.dart
@@ -43,5 +43,8 @@ class GridPainter extends CustomPainter {
  }
 
  @override
- bool shouldRepaint(CustomPainter oldDelegate) => false;
+ bool shouldRepaint(GridPainter oldDelegate) =>
+ !identical(horizontalLines, oldDelegate.horizontalLines) ||
+ !identical(tabContext, oldDelegate.tabContext) ||
+ !identical(verticalLines, oldDelegate.verticalLines);
 }
diff --git a/lib/display/measure_display.dart b/lib/display/measure_display.dart
@@ -151,7 +151,12 @@ class MeasureChartPainter extends CustomPainter {
  }
 
  @override
- bool shouldRepaint(CustomPainter oldDelegate) => false;
+ bool shouldRepaint(MeasureChartPainter oldDelegate) =>
+ !identical(chartPositioning, oldDelegate.chartPositioning) ||
+ !identical(instrument, oldDelegate.instrument) ||
+ !identical(last, oldDelegate.last) ||
+ !identical(measure, oldDelegate.measure) ||
+ !identical(tabContext, oldDelegate.tabContext);
 }
 
 extension RepeatCircleCenterFns on Instrument {
@@ -275,5 +280,10 @@ class MeasureNotePainter extends CustomPainter {
  }
 
  @override
- bool shouldRepaint(CustomPainter oldDelegate) => false;
+ bool shouldRepaint(MeasureNotePainter oldDelegate) =>
+ !identical(chartPositioning, oldDelegate.chartPositioning) ||
+ !identical(measure, oldDelegate.measure) ||
+ !identical(noteLabelPaint, oldDelegate.noteLabelPaint) ||
+ !identical(notePositioning, oldDelegate.notePositioning) ||
+ !identical(tabContext, oldDelegate.tabContext);
 }