-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement round, floor, ceil on the LLVM backend #606
Conversation
Oops, I thought we were linking |
val linkedLibraries = Seq( | ||
"-lm", // Math library | ||
) ++ libuvArgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @phischu, do you foresee any problems with linking in -lm
in the LLVM backend?
This is only relevant when using gcc
, it works fine without it on clang
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an actual problem, just that this is the beginning of a never ending stream of C libraries we are linking against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be subtle differences between the backends, but I don't care.
val linkedLibraries = Seq( | ||
"-lm", // Math library | ||
) ++ libuvArgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an actual problem, just that this is the beginning of a never ending stream of C libraries we are linking against.
Cherry-picked from #542.
I don't really know why the tests fail on CI: the intrinsics are there from at least LLVM 12, and it does work locally...The CI
failsfailed with:See below for the resolution.