Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LSP autocomplete #384

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

marvinborner
Copy link
Member

@marvinborner marvinborner commented Jan 29, 2024

This PR closes #367. Together with effekt-lang/kiama#1 and effekt-lang/effekt-vscode#16, this should result in first steps towards more intelligent LSP intelligence.

Main things still missing:

  • Better symbol selection; for now all suggested completion items are selected by prefix of the currently typed word
  • Only suggest symbols in AST within the scope of the current position; this is especially hard since the tree often has syntax errors while completing; for now all symbols in the AST get suggested
  • Be much more smart about completion suggestions, e.g. dot notation should only suggest relevant sub items, else should only be shown if within if, effect handlers could be autocompleted (LSP can write entire snippets) etc. This is probably too much for this initial PR.

I very much welcome criticism and suggestions for elegant solutions. I'm still unfamiliar with Scala and the code base.

@marvinborner marvinborner marked this pull request as ready for review February 27, 2024 14:34
@jiribenes jiribenes force-pushed the master branch 3 times, most recently from ee9d209 to 58c8510 Compare October 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP autocomplete keywords and identifiers
1 participant