Try to update syntax highlighting #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiribenes
force-pushed
the
jiribenes/syntax-update
branch
from
1fea08d
to
a6eae04
Compare
jiribenes
commented
Jul 20, 2024
Comment on lines
-69
to
-72
| var CLASS = { | ||
| className: 'class', | ||
| beginKeywords: 'class object trait type', | ||
| end: /[:={\[\n;]/, |
There was a problem hiding this comment.
I don't think we really used this anywhere except for type declarations so I merged the important parts with METHOD to make DEFINITION.
|
Hey @dvdvgt, if you get some time, could you just try if this highlighting looks okay to you on your local website build? |
dvdvgt
reviewed
Sep 10, 2024
src/effekt-syntax.ts
Outdated
Comment on lines
89
to
90
| [/\/\*/, 'comment', '@push'], | ||
| ["\\*/", 'comment', '@pop'], |
There was a problem hiding this comment.
Apparently this does not work (as before):
/*
* Used as a type for `Exception` in functions which expect a non-empty
* container (e.g. option or list).
*/
record MissingValue()
Here, the lines following beyond the */ are also greyed out
| ], | ||
|
|
||
| bracketCounting: [ | ||
| [/\{/, 'delimiter.bracket', '@bracketCounting'], |
There was a problem hiding this comment.
This does seem to get confused on this example:
extern io def panic[R](msg: String): R =
js "${ msg ++ "{42}"}"
Here, the 42 is coloured like a literal (blue) while it should coloured like a string (green)
|
I tried fixing the two outlined things, PTAL. 🙏 |
dvdvgt
reviewed
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This has NOT been tested!
In sync with effekt-lang/effekt-vscode#18, let's try to update the syntax files a little bit.
Here I attempted to keep things mostly as they are, remove extremely outdated parts and port (at least some of) the changes from effekt-lang/effekt-vscode#18.
Also, sorry for the wrong push in 8927cc8. 🙏