Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration tests for the pre-enrollments api AP-1405 #289

Merged
merged 12 commits into from
Oct 18, 2024
Merged

feat: add integration tests for the pre-enrollments api AP-1405 #289

merged 12 commits into from
Oct 18, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Oct 9, 2024 •
edited by jira bot
Loading

Description

This PR adds integration tests for the pre-enrollment API. These tests are executed in the job of Tutor Integration Tests

Testing instructions

Check the jobs of Tutor Integration Tests in the PR.

Jira Issue

@github-actions github-actions bot added the size/m label Oct 9, 2024
@BryanttV BryanttV changed the title feat: add integration tests for the enrollments api AP-1405 feat: add integration tests for the pre-enrollments api AP-1405 Oct 9, 2024
@github-actions github-actions bot added size/l and removed size/m labels Oct 11, 2024
@BryanttV BryanttV force-pushed the bav/integration-tests-to-pre-enrollment-api branch 3 times, most recently from 6eacbb0 to 6a87303 Compare October 15, 2024 14:33
@BryanttV BryanttV marked this pull request as ready for review October 15, 2024 14:46
@BryanttV BryanttV requested a review from a team as a code owner October 15, 2024 14:46
@BryanttV BryanttV force-pushed the bav/integration-tests-to-pre-enrollment-api branch 2 times, most recently from b20cad9 to c900d23 Compare October 16, 2024 19:02
magajh
magajh reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @BryanttV! I just have a couple of comments

eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Show resolved Hide resolved
mariajgrimaldi
mariajgrimaldi requested changes Oct 17, 2024
View reviewed changes
eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
eox_core/api/v1/tests/integration/test_views.py Outdated Show resolved Hide resolved
magajh
magajh approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanttV thanks! LGTM and I don't have any more comments, so I'm leaving my approval

mariajgrimaldi
mariajgrimaldi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing all of our comments. LGTM!

@BryanttV BryanttV mentioned this pull request Oct 18, 2024
Open
@BryanttV BryanttV merged commit c1171e3 into master Oct 18, 2024
11 checks passed
luisfelipec95 pushed a commit that referenced this pull request Oct 22, 2024
@BryanttV @luisfelipec95
feat: add integration tests for the pre-enrollments api AP-1405 (#289)
0fc7569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magajh magajh magajh approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BryanttV @magajh @mariajgrimaldi