Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conform-zod): refine should be run by default #208

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(conform-zod): refine should be run by default #208

merged 1 commit into from
Jul 11, 2023

Conversation

edmundhung
Copy link
Owner

@edmundhung edmundhung commented Jul 10, 2023 •
edited
Loading

Fix #207.

The refine helper should run the refinement if the when option is undefined.

@edmundhung edmundhung mentioned this pull request Jul 10, 2023
Closed
@edmundhung edmundhung changed the title fix(conform-zod): when should default to true fix(conform-zod): refine should be run by default Jul 10, 2023
@edmundhung edmundhung changed the base branch from main to next July 11, 2023 20:32
@edmundhung edmundhung merged commit f8e3554 into next Jul 11, 2023
2 checks passed
@edmundhung edmundhung deleted the refine-missing-default branch July 11, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation Skipped in Conform Async Validation in Remix Application
1 participant
@edmundhung