Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: use GCP REST API for instance templates #3361

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Sep 17, 2024

Context

GCP upgrades were broken previously as new nodes didn't use the correct instance types. This was caused by the Protobuf-based GCP Go SDK isn't aware of the confidential_instance_type field, which thus wasn't copied when creating a new instance template during an upgrade. This can be circumvented by using the REST API implementation, which is aware of the field.

Proposed change(s)

  • Use the GCP REST API (the corresponding Go SDK, really) for managing instance templates during an upgrade.

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Sep 17, 2024
@msanft msanft added this to the v2.18.0 milestone Sep 17, 2024
@msanft msanft requested a review from 3u13r as a code owner September 17, 2024 14:17
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 158b120
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66e99c04723c4200083d8ba4

@msanft
Copy link
Contributor Author

msanft commented Sep 17, 2024

From my manual testing, it seems that this patch is not sufficient to make SEV-SNP upgrades on GCP work again. Anyhow, I verified that this fix alone is correct by checking that instance templates now use the correct confidential instance type, so I think this fix should be merged in either case.

Copy link
Contributor

Coverage report

Package Old New Trend
operators/constellation-node-operator/internal/cloud/gcp/client 43.90% 43.70% ↘️

@msanft msanft merged commit effb086 into main Sep 18, 2024
10 checks passed
@msanft msanft deleted the msanft/operator/rest-api branch September 18, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants