terraform: azure remove unused lb backends #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
3u13r
force-pushed
the
ref/terraform/azure-remove-unused-lb-backends
branch
3 times, most recently
from
7f0af4d
to
a22c79b
Compare
daniel-weisse
approved these changes
Jul 25, 2024
burgerdev
approved these changes
Jul 25, 2024
3u13r
force-pushed
the
ref/terraform/azure-remove-unused-lb-backends
branch
from
a22c79b
to
452bdf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a prerequisite for ignoring changes to the load balancer backends attached to the NICs of the VMs in #3257
They need to be ignored since K8s LBs also creates a new backend which is attached to the NICs of the VMs. See https://github.com/edgelesssys/constellation/actions/runs/10032636133 for the error currently occurring on the other PR.
Proposed change(s)
upgrade test, azure:
https://github.com/edgelesssys/constellation/actions/runs/10067834089https://github.com/edgelesssys/constellation/actions/runs/10086213264
Additional info
This is part of a larger story, where we fix the issue that K8s LBs change the state of the cloud resources tracked in Terraform, which results in a diff of the state and issues when upgrading Constellation.
For the missing dependencies in Azure, see: hashicorp/terraform-provider-azurerm#4398 (comment)
Checklist