-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image: mkosi from nixpkgs #2360
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
e9ad93b
to
00b73e2
Compare
|
||
devShells.default = import ./nix/shells/default.nix { pkgs = pkgsUnstable; }; | ||
|
||
formatter = nixpkgsUnstable.legacyPackages.${system}.nixpkgs-fmt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a formatter/linter/instantiate workflow to the CI (not in this PR, but soon).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image builds complete successfully on NixOS after a cache clean, nice work!🤟
Co-authored-by: Paul Meyer <[email protected]>
Co-authored-by: Paul Meyer <[email protected]>
Co-authored-by: Paul Meyer <[email protected]>
9284498
to
08d3e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image build worked for me on Fedora 37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit. Works on Ubuntu 22.04. Did not really review the bazel code as it is too complex for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't build the image (on Mac) and have only overlooked the Terraform changes. Should we document the change to disabled secure boot on GCP?
I'll document this and also update the docs with the boot measurement table |
60f6cd4
to
db79823
Compare
db79823
to
0820989
Compare
Coverage report
|
Context
This is a large step towards reproducible OS image builds. With this change, mkosi and all required tools are installed with nix.
In a follow up step, we will pin all RPMs required to build a Fedora image.
Proposed change(s)
bazel build
directly on NixOS)How to review
Since this PR is quite large, it is probably a good idea to not have everyone review it in full.
Instead, review a part that you are the expert of and comment what you reviewed.
Also, please test if you can build an image on your (Linux) workstation.
How to test
ref/feat-image-nix-mkosi-toolchain/stream/debug/v2.12.0-pre.0.20230926093438-08d3e02d2353
common --config=nix
to.bazeloverwriterc
and build images (see image/README.md)common --config=nix
to.bazeloverwriterc
bazel clean --expunge
and build images (see image/README.md)Checklist