bazel: adopt best practices for bazelrc #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
malt3
force-pushed
the
fix/bazel/bazelrc-best-practices
branch
9 times, most recently
from
c3f7a07
to
cc42ce0
Compare
Options adapted from https://docs.aspect.build/guides/bazelrc bazel: adopt best practices for bazelrc Options adapted from https://docs.aspect.build/guides/bazelrc
malt3
force-pushed
the
fix/bazel/bazelrc-best-practices
branch
from
730ebe8
to
9de510b
Compare
malt3
requested review from
daniel-weisse,
3u13r and
katexochen
as code owners
Envtests require networking, strict sandbox only allows networking if tag is set. See https://bazel.build/reference/be/common-definitions#common.tags for further explanation.
malt3
force-pushed
the
fix/bazel/bazelrc-best-practices
branch
from
c27eddb
to
7efc611
Compare
daniel-weisse
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Options adapted from https://docs.aspect.build/guides/bazelrc
Proposed change(s)
Checklist