Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: fix ccm config with correct uami client_id #2144

Merged
merged 2 commits into from
Aug 1, 2023
Merged

azure: fix ccm config with correct uami client_id #2144

merged 2 commits into from
Aug 1, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Jul 31, 2023

Context

#2136 introduced a bug by providing the name of the UAMI in the azureConfig secret, instead of the expected client_id.

Proposed change(s)

  • inject the client_id correctly

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@elchead elchead requested a review from katexochen as a code owner July 31, 2023 13:59
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 78f7d68
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/64c8a45d54c6b6000851bbb1

@elchead elchead force-pushed the fix/azure/config-uami-client-id branch from 214ae4b to 03a1a16 Compare July 31, 2023 14:10
@elchead
Copy link
Contributor Author

elchead commented Jul 31, 2023 •
edited
Loading

running e2e:
latest: https://github.com/edgelesssys/constellation/actions/runs/5716246802 ✅
before rename: https://github.com/edgelesssys/constellation/actions/runs/5716191364✅
main: https://github.com/edgelesssys/constellation/actions/runs/5716242713 ❌ as expected

@elchead elchead force-pushed the fix/azure/config-uami-client-id branch from 17a76fa to 0b5891e Compare July 31, 2023 15:41
@katexochen katexochen removed their request for review July 31, 2023 16:21
@elchead elchead force-pushed the fix/azure/config-uami-client-id branch from 0b5891e to 78f7d68 Compare August 1, 2023 06:21
@elchead elchead merged commit 2648001 into main Aug 1, 2023
5 checks passed
@elchead elchead deleted the fix/azure/config-uami-client-id branch August 1, 2023 06:40
@elchead elchead added the no changelog Change won't be listed in release changelog label Aug 1, 2023
@elchead elchead added this to the v2.10.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elchead @daniel-weisse