Skip to content

Commit

Permalink
s3proxy: remove unnecessary pull secret
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasten authored and derpsteb committed Oct 11, 2023
1 parent a1c84cb commit f696cb4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions docs/docs/getting-started/examples/filestash-s3proxy.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ spec:
labels:
app: filestash
spec:
imagePullSecrets:
- name: regcred
hostAliases:
- ip: $(kubectl get svc s3proxy-service -o=jsonpath='{.spec.clusterIP}')
hostnames:
Expand Down Expand Up @@ -54,6 +52,7 @@ If you followed the s3proxy [Deployment](../../workflows/s3proxy.md#deployment)

To use other regions than `eu-west-1`, add more entries to `hostAliases` for all regions you require.
Use the same IP for those entries. For example to add `us-east-1` add:

```yaml
- ip: $(kubectl get svc s3proxy-service -o=jsonpath='{.spec.clusterIP}')
hostnames:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ spec:
labels:
app: filestash
spec:
imagePullSecrets:
- name: regcred
hostAliases:
- ip: $(kubectl get svc s3proxy-service -o=jsonpath='{.spec.clusterIP}')
hostnames:
Expand Down Expand Up @@ -54,6 +52,7 @@ If you followed the s3proxy [Deployment](../../workflows/s3proxy.md#deployment)

To use other regions than `eu-west-1`, add more entries to `hostAliases` for all regions you require.
Use the same IP for those entries. For example to add `us-east-1` add:

```yaml
- ip: $(kubectl get svc s3proxy-service -o=jsonpath='{.spec.clusterIP}')
hostnames:
Expand Down
4 changes: 2 additions & 2 deletions s3proxy/deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
The VPN is a feature of Constellation and will not be present by default in other environments.

Disclaimer: the following steps will be automated next.

- Within `constellation/build`: `bazel run //:devbuild`
- Copy the container name displayed for the s3proxy image. Look for the line starting with `[@//bazel/release:s3proxy_push]`.
- Replace the image key in `deployment-s3proxy.yaml` with the image value you just copied. Use the sha256 hash instead of the tag to make sure you use the latest image.
Expand Down Expand Up @@ -32,8 +33,6 @@ spec:
labels:
app: filestash
spec:
imagePullSecrets:
- name: regcred
hostAliases:
- ip: $(kubectl get svc s3proxy-service -o=jsonpath='{.spec.clusterIP}')
hostnames:
Expand All @@ -60,4 +59,5 @@ $ kubectl apply -f deployment-filestash.yaml
```

Afterwards you can use a port forward to access the Filestash pod:

- `kubectl port-forward pod/$(kubectl get pod --selector='app=filestash' -o=jsonpath='{.items[*].metadata.name}') 8443:8443`
2 changes: 0 additions & 2 deletions s3proxy/deploy/deployment-s3proxy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ spec:
labels:
app: s3proxy
spec:
imagePullSecrets:
- name: regcred
containers:
- name: s3proxy
image: ghcr.io/edgelesssys/constellation/s3proxy:v2.12.0
Expand Down

0 comments on commit f696cb4

Please sign in to comment.