Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-2979] Analytics integration tests continuation #810

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[MOB-2979] Analytics integration tests continuation #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a8211df
[MOB-2979] Add `Welcome` and `WelcomeTour` Analytics tests
d4r1091 Nov 8, 2024
1068840
[MOB-2979] Add `NewsController` Analytics tests
d4r1091 Nov 8, 2024
a40ad58
[MOB-2979] Add `MultiplyImpact` Analytics tests
d4r1091 Nov 8, 2024
72a9c57
[MOB-2979] Add `TopSites` Analytics tests
d4r1091 Nov 8, 2024
f1e906d
[MOB-2979] Add `AboutEcosia` learn more Analytics tests
d4r1091 Nov 8, 2024
c2b9da2
[MOB-2979] Update comments to the `AnalyticsSpyTests`
d4r1091 Nov 8, 2024
9a896a6
Remove redundant `Foundation` import
d4r1091 Nov 11, 2024
342938e
Fix `large_tuple` linting
d4r1091 Nov 11, 2024
207f6cc
Fix news model
d4r1091 Nov 13, 2024
e333885
[MOB-2979] Review expectations
d4r1091 Nov 13, 2024
7e19c5d
[MOB-2979] Add custom condition
d4r1091 Nov 13, 2024
b3eb9b6
[MOB-2979] Fix unwrap of copycontrol and learnmorebutton
d4r1091 Nov 13, 2024
c41455f
Update overall tests
Nov 13, 2024
ef1de07
Allow `.allEvents` in UIControl
Nov 14, 2024
300c78c
Improve delay in `lunch` and `resume` events
Nov 14, 2024
7a6f0e4
Update analytics tests
Nov 14, 2024
6f78f66
Swift lint checks update
Nov 14, 2024
4d03dac
Remove flaky `testMultiplyImpactCopyCodeTracksReferralClickLinkCopying`
Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Client.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,8 @@
2C872A622B8CD7E000B318A0 /* VersionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CE294702B7FC5A6006C22B2 /* VersionTests.swift */; };
2C872A632B8CD7E000B318A0 /* WhatsNewLocalDataProviderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CE2946B2B7FC5A5006C22B2 /* WhatsNewLocalDataProviderTests.swift */; };
2C872A642B8CD7E000B318A0 /* EcosiaHomeViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C872A562B8CD65100B318A0 /* EcosiaHomeViewModelTests.swift */; };
2C9A62C02CDE1F7600CDA7D1 /* MockWelcomeDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C9A62BF2CDE1F7600CDA7D1 /* MockWelcomeDelegate.swift */; };
2C9A62C22CDE4A3B00CDA7D1 /* MockNewsModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2C9A62C12CDE4A3B00CDA7D1 /* MockNewsModel.swift */; };
2CA995282CA2C06A001064CC /* NTPConfigurableNudgeCardCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CA995272CA2C06A001064CC /* NTPConfigurableNudgeCardCell.swift */; };
2CA9952A2CA2C0BB001064CC /* NTPConfigurableNudgeCardCellViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 2CA995292CA2C0BB001064CC /* NTPConfigurableNudgeCardCellViewModel.swift */; };
2CABD7162C11C9CC00A0750F /* MozillaAppServices in Frameworks */ = {isa = PBXBuildFile; productRef = 2CABD7152C11C9CC00A0750F /* MozillaAppServices */; };
Expand Down Expand Up @@ -2512,6 +2514,8 @@
2C8C07761E7800EA00DC1237 /* FindInPageTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FindInPageTests.swift; sourceTree = "<group>"; };
2C9144B0B15218D8A0FCD538 /* es-AR */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "es-AR"; path = "es-AR.lproj/ClearPrivateData.strings"; sourceTree = "<group>"; };
2C97EC701E72C80E0092EC18 /* TopTabsTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TopTabsTest.swift; sourceTree = "<group>"; };
2C9A62BF2CDE1F7600CDA7D1 /* MockWelcomeDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockWelcomeDelegate.swift; sourceTree = "<group>"; };
2C9A62C12CDE4A3B00CDA7D1 /* MockNewsModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockNewsModel.swift; sourceTree = "<group>"; };
2CA16FDD1E5F089100332277 /* SearchTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchTest.swift; sourceTree = "<group>"; };
2CA995272CA2C06A001064CC /* NTPConfigurableNudgeCardCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NTPConfigurableNudgeCardCell.swift; sourceTree = "<group>"; };
2CA995292CA2C0BB001064CC /* NTPConfigurableNudgeCardCellViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NTPConfigurableNudgeCardCellViewModel.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -8878,6 +8882,8 @@
isa = PBXGroup;
children = (
2C872A532B8CD47600B318A0 /* MockAppVersionInfoProvider.swift */,
2C9A62BF2CDE1F7600CDA7D1 /* MockWelcomeDelegate.swift */,
2C9A62C12CDE4A3B00CDA7D1 /* MockNewsModel.swift */,
);
path = Mocks;
sourceTree = "<group>";
Expand Down Expand Up @@ -14483,6 +14489,7 @@
C29B64872AD69D0200F3244B /* QRCodeCoordinatorTests.swift in Sources */,
0BA8964B1A250E6500C1010C /* ProfileTest.swift in Sources */,
8AE80BAF2891960300BC12EA /* MockTraitCollection.swift in Sources */,
2C9A62C22CDE4A3B00CDA7D1 /* MockNewsModel.swift in Sources */,
E19443F82AF953B000964EA5 /* MockSidebarEnabledView.swift in Sources */,
8A832A9729DCBD3C0025D5DD /* LaunchTypeTests.swift in Sources */,
8A28C628291028870078A81A /* CanRemoveQuickActionBookmarkTests.swift in Sources */,
Expand Down Expand Up @@ -14566,6 +14573,7 @@
C2B808B12A77FA3F00A65487 /* DownloadsCoordinatorTests.swift in Sources */,
5A475E9129DB8AA7009C13FD /* MockDiskImageStore.swift in Sources */,
DFA51484276103A000266AA0 /* HistoryHighlightsManagerTests.swift in Sources */,
2C9A62C02CDE1F7600CDA7D1 /* MockWelcomeDelegate.swift in Sources */,
C2506C952A6A8D2600F2B76E /* HistoryCoordinatorTests.swift in Sources */,
8ADAFAC628AEBF6300FFEBE3 /* HomeLogoHeaderViewModelTests.swift in Sources */,
E14BF33E2950B1230039758D /* MailProvidersTests.swift in Sources */,
Expand Down
8 changes: 4 additions & 4 deletions Client/Ecosia/UI/MultiplyImpact/MultiplyImpact.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import MobileCoreServices
import LinkPresentation
import Common

final class MultiplyImpact: UIViewController, Themeable {
class MultiplyImpact: UIViewController, Themeable {

// MARK: - UX

Expand Down Expand Up @@ -79,15 +79,15 @@ final class MultiplyImpact: UIViewController, Themeable {

private weak var sharingYourLink: UILabel?
private weak var sharing: UIView?
private weak var copyControl: UIControl?
private(set) weak var copyControl: UIControl?
private weak var copyLink: UILabel?
private weak var copyText: UILabel?
private weak var copyDividerLeft: UIView?
private weak var copyDividerRight: UIView?
private weak var moreSharingMethods: UILabel?
private weak var inviteButton: EcosiaPrimaryButton!
private(set) weak var inviteButton: EcosiaPrimaryButton!

private weak var learnMoreButton: UIButton?
private(set) weak var learnMoreButton: UIButton?

private weak var flowTitle: UILabel?
private weak var flowBackground: UIView?
Expand Down
2 changes: 1 addition & 1 deletion Client/Ecosia/UI/NTP/AboutEcosia/NTPAboutEcosiaCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ final class NTPAboutEcosiaCell: UICollectionViewCell, ReusableCell {
label.setContentCompressionResistancePriority(.init(rawValue: 0), for: .horizontal)
return label
}()
private lazy var learnMoreButton: UIButton = {
private(set) lazy var learnMoreButton: UIButton = {
let button = UIButton()
button.translatesAutoresizingMaskIntoConstraints = false
button.layer.borderWidth = 1
Expand Down
2 changes: 1 addition & 1 deletion Client/Ecosia/UI/NTP/News/NewsController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Common

final class NewsController: UIViewController, UICollectionViewDelegate, UICollectionViewDataSource,
UICollectionViewDelegateFlowLayout, Themeable {
private weak var collection: UICollectionView!
private(set) weak var collection: UICollectionView!
private var items = [NewsModel]()
private let images = Images(.init(configuration: .ephemeral))
private let news = News()
Expand Down
Loading
Loading