Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-1352] Reset cron scheduler and stale/close times back to normal values and delete stale branches #43

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Mar 14, 2024

Reset cron scheduler values back to once per day

Reset stale/close times back to 45/15 (or something else) from 1/1 used for testing

Delete stale branch when PR is stale for X days


You can see this action was tested in my forked repo here: xbtmatt#4

and the github action that triggered the branch deletion is here: https://github.com/xbtmatt/econia-v5/actions/runs/8276253969/job/22644504793

Do note that the grace period for deleting a stale PR/issue can sometimes be longer than the period between the last run in CI due to the variance in scheduler times.

That is, if the branch is deleted after being stale for 1 day and the github action runs again, 23 hours 58 minutes and 39 seconds after marking it as stale, it won't delete it that day, because it technically has been stale for < 1 day. This isn't a big deal but it is something to note.

@xbtmatt xbtmatt requested a review from alnoki March 14, 2024 06:26
@xbtmatt xbtmatt self-assigned this Mar 14, 2024
@alnoki alnoki merged commit 7e47029 into main Mar 14, 2024
1 check passed
@alnoki alnoki deleted the ECO-1352 branch March 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants