Fix "dot-separated" paths by making paths type string[] (instead of string)
#1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this can't be merged now. Because of conflicts with unfixed packages (angular, vue, ...). But those can be fixed, as well. |
mirismaili
force-pushed
the
fix-dot-separated-path
branch
from
47d5daf
to
58413e1
Compare
|
Hi @mirismaili, thanks for the PR. We're already working on this, see #1831 The main problem with the array approach is to not lose performance. Just replacing strings with arrays here will lead to massive degradation as the memoization of React will no longer work and therefore the whole form will rerender with every change. |
… `string`) for react (in these packages: "core", "react" and "material-renderers") eclipsesource#1849 eclipsesource#1831
mirismaili
force-pushed
the
fix-dot-separated-path
branch
from
58413e1
to
d45775d
Compare
|
Hi, Has the "dot-seperated" issue been resolved yet? |
|
We came up with a better solution, documented it in #2153 and will start developing it soon. Therefore I'll close this PR as it's outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "dot-separated" paths by making paths type
string[](instead ofstring) for react (in these packages: "core", "react" and "material-renderers")#1849
#1831