Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation/migration note to Databroker #762

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

erikbosch
Copy link
Contributor

Intended workflow:

  • Merge this one
  • Then tag repo with 0.4.3
  • Then trigger ghcr containers for 0.4.3

After that we may consider removing Databroker code from this repo

Note: This one shall maybe not be merged until we have performed sufficient testing on new repo, so that we can
release 0.4.4 in new repo at about the same time

@SebastianSchildt
Copy link
Contributor

So maybe workflow should be "release in in new Repo first", then do the steps above?

@erikbosch
Copy link
Contributor Author

So maybe workflow should be "release in in new Repo first", then do the steps above?

Yes, that works as well and is less ambiguous

@erikbosch
Copy link
Contributor Author

@SebastianSchildt - a pre-release of https://github.com/eclipse-kuksa/kuksa-databroker/releases/tag/0.4.4 now exists, so now I think this one is ready for approval and merge

@SebastianSchildt
Copy link
Contributor

Not sure, there was a very scary NOTICE.,d with lots of bullshit attached to the releases. I was thinking deleting the release, but for now just remove the file (I have a local copy). We should investigate where that came from

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@SebastianSchildt
Copy link
Contributor

I digged deeper on the Notice, it was just an super outdated file (that never made much sense anyway). So I "fixed" it here eclipse-kuksa/kuksa-databroker#13 but please check @erikbosch

@erikbosch
Copy link
Contributor Author

.

So are there any changes required in this PR/repo @SebastianSchildt?

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erikbosch . Not really. Yesterday I was just not sure, this is a bigger thing that will block us some time. So I think not. The release is "fixed", the other PR, we should merge sime time after.

So this one COULD be merged, I did not actually test /check the changes here so I can not "approve" just yet

@erikbosch
Copy link
Contributor Author

I have done a smoke test, starting databroker+dtabroker-cli and made sure they can talk to each other

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🦒

@SebastianSchildt SebastianSchildt merged commit 040416e into eclipse:master Apr 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants