Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3654 Support for JSON-LD 1.1 #4852

Merged
merged 2 commits into from
Mar 18, 2024
Merged

GH-3654 Support for JSON-LD 1.1 #4852

merged 2 commits into from
Mar 18, 2024

Conversation

hmottestad
Copy link
Contributor

@hmottestad hmottestad commented Dec 1, 2023

GitHub issue resolved: #3654

Briefly describe the changes proposed in this PR:

  • moved old JSON-LD code to a new module named jsonld-legacy
  • implemented support for everything except hierarchical mode using HASMAC-JSON-LD, a fork of Titanium JSON-LD with performance improvements and modifications to make the integration with RDF4J simpler

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad
Copy link
Contributor Author

hmottestad commented Mar 4, 2024

TODO:

  • Support for framing
  • License fix

@@ -32,6 +32,7 @@
import java.io.OutputStreamWriter;
import java.io.Reader;
import java.io.Writer;
import java.nio.charset.StandardCharsets;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: Optimize imports

@hmottestad hmottestad force-pushed the GH-3654-jsonld11 branch 2 times, most recently from 78adddd to 3cb97d1 Compare March 14, 2024 10:18
@hmottestad
Copy link
Contributor Author

hmottestad commented Mar 14, 2024

Develop branch

Benchmark                               Mode  Cnt     Score     Error  Units
ReadWriteBenchmark.parseFromString      avgt    5  2163.850 ± 183.838  ms/op
ReadWriteBenchmark.writeToStringWriter  avgt    5  2136.912 ± 137.561  ms/op

This branch

Benchmark                               Mode  Cnt     Score     Error  Units
ReadWriteBenchmark.parseFromString      avgt    5  1491.179 ± 133.298  ms/op
ReadWriteBenchmark.writeToStringWriter  avgt    5  3518.826 ± 556.206  ms/op

Develop branch is faster at writing JSON-LD. Might be worth looking into, but the difference isn't too bad.

@hmottestad hmottestad merged commit c9f6b06 into develop Mar 18, 2024
8 of 9 checks passed
@hmottestad hmottestad deleted the GH-3654-jsonld11 branch March 18, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant