Find/Replace Logic: Allow reset of Incremental Base Position

[Wittmaxi]

Allow the client to reset the base position for incremental search without enabling/disabling the Incremental search.

fixes #1913

[github-actions]

Test Results

 1 815 files  +  601   1 815 suites  +601   1h 35m 54s ⏱️ + 19m 14s
 7 678 tests +    1   7 450 ✅ +  251  228 💤  -   5  0 ❌ ±0 
24 195 runs  +7 043  23 446 ✅ +7 072  749 💤 +226  0 ❌ ±0 

Results for commit ecb803a. ± Comparison against base commit 8534560.

♻️ This comment has been updated with latest results.

[Wittmaxi]

@HeikoKlare I am not sure what is failing here. Can you please have a look?

[HeikoKlare]

The change is almost good to go. It provides a dedicated way of resetting the incremental base position, which removes a workaround in the find/replace overlay. I only have two minor comments regarding documentation.

Just one further thought on the design of the FindReplaceLogic: In the long term, I hope that we find a design which does not require the consumer of the FindReplaceLogic to think about when to reset the incremental base position, but that the logic provides a proper level of abstraction in it's functionality so that resetting the incremental base position can be hidden within it. But let's see if that will be possible and reasonable, or if that would require to increase the level of abstraction of the FindReplaceLogic too far. With this change, we can first make the behavior of incremental base position updates consistent and provide regression proper tests before maybe improving the design again.

[HeikoKlare]

@HeikoKlare I am not sure what is failing here. Can you please have a look?

The failure was because of this issue: eclipse-pde/eclipse.pde#1310

Note that this kind of failure makes the build for that OS fail immediately, so you should restart the job as you might miss broken tests or other failures specific to that OS otherwise.

[Wittmaxi]

@HeikoKlare once the tests run through and you give me your OK, I will merge this

[HeikoKlare]

Thank you for the final improvement! This is good to go from my side.

Feel free to merge once the builds/checks have succeeded.