Skip to content

Commit

Permalink
Find/replace dialog: properly update search string #2322
Browse files Browse the repository at this point in the history
The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes #2322
  • Loading branch information
HeikoKlare committed Sep 26, 2024
1 parent 62abff0 commit 5aee5c5
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ private void ignoreNextEvent() {

@Override
public void modifyText(ModifyEvent e) {
modificationHandler.run();
// XXX: Workaround for Combo bug on Linux (see bug 404202 and bug 410603)
if (fIgnoreNextEvent) {
fIgnoreNextEvent = false;
return;
}
modificationHandler.run();
evaluateFindReplaceStatus();

updateButtonState(!findReplaceLogic.isActive(SearchOptions.INCREMENTAL));
Expand Down

0 comments on commit 5aee5c5

Please sign in to comment.