Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webapp to Java 17 and update jetty jspc #102

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Move webapp to Java 17 and update jetty jspc #102

merged 6 commits into from
Mar 14, 2023

Conversation

akurtakov
Copy link
Member

Move webapp to Java 17.

@akurtakov akurtakov changed the title Build jsps with Jetty 10.0.14 Move webapp to Java 17 and update jetty jspc Mar 13, 2023
@akurtakov
Copy link
Member Author

@laeubi
Copy link
Contributor

laeubi commented Mar 13, 2023

The API tools fail with:

File TipsStartupService.java at line 35: The import org.osgi.service.component cannot be resolved

This might be a bug in tycho-dependency-tools-plugin or nothing can be found at the target platform, if you can build this local, there should be a "dependeices.txt" or something in the target folder that list all items, I can try to take a look later if I see what happens here, but UI seems always a bit special, so maybe one needs to add an extra requirement here?

@akurtakov
Copy link
Member Author

In local build there is /home/akurtakov/.m2/repository/org/osgi/org.osgi.service.component/1.5.1/org.osgi.service.component-1.5.1.jar in target/dependencies-list.txt file.

@mickaelistria
Copy link
Contributor

I can reproduce the build issue from master, then mvn clean verify -Pbuild-individual-bundles -Papi-check -pl org.eclipse.tips.ide.

I'm trying to debug with java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=1044 -Xmx2048M -jar /home/mistria/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.400.v20210924-0641/org.eclipse.equinox.launcher-1.6.400.v20210924-0641.jar -install /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace -configuration /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/configuration -data /home/mistria/git/eclipse.platform.ua/apiAnalyzer-workspace/data -application org.eclipse.pde.api.tools.apiAnalyzer -project /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide -baseline /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/org.eclipse.tips.ide-apiBaseline.target -dependencyList /home/mistria/git/eclipse.platform.ua/org.eclipse.tips.ide/target/dependencies-list.txt -failOnError (the command generated by eclipse-run, with addition of debugging agent), when connecting to the application, I can see that the target platform seems to be properly resolved, includes the org.osgi.service.component bundle, that the org.eclipse.tips.ide project is imported but I don't see org.osgi.service.component in its resolved classpath (while both Tycho and PDE in my IDE seem to add it to the classpath).

`

@laeubi
Copy link
Contributor

laeubi commented Mar 14, 2023

while both Tycho and PDE in my IDE seem to add it to the classpath

Yes PDE do this automatically (also Tycho), but I don't know if that also applies to the API tools (e.g. do they use a full pde-core project setup?) Maybe something is required here due to the new release cycle so it can't fetch all requirements?!?

@mickaelistria
Copy link
Contributor

Let's continue discussion about this API Tools issue in #103

It has been agreed that 2023-06 will require Java 17
"core" profile is not available by default.
Bump the minor as the feature now contains bundles that require Java 17
@akurtakov akurtakov merged commit cc21743 into eclipse-platform:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants