fix MQTTDeserialize_unsubscribe didn't judge maxcount or may cause memory access violation #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: brucemaclin <[email protected]>
|
We'll also need a UT for validation. |
CIPop
suggested changes
Mar 4, 2024
| @@ -81,6 +81,8 @@ int32_t MQTTDeserialize_unsubscribe(unsigned char* dup, unsigned short* packetid | |||
| *count = 0; | |||
| while (curdata < enddata) | |||
| { | |||
| if (*count == maxcount) | |||
There was a problem hiding this comment.
>= is safer.
Also, we'll need to scan all other APIs for possible similar issues.
There was a problem hiding this comment.
change to >=.But in MQTTV5Deserialize_subscribe,it use *count == maxcount to check.
Signed-off-by: brucemaclin <[email protected]>
Signed-off-by: brucemaclin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an invalid unsubscribe packet in base64 format "rS8BAAABAAAAAAAADGlvdC0wNDBhMDFrcARtcXR0BmlvdGh1YghhbGl5dW5jcwNjbw=="
if set maxcount to 1,and init topicFilters with size 1,*count will bigger than maxcount,topicFilters[*count] cause memory access violation.