Exporting the -static CMake targets when both shared and static libraries built. #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumoog
approved these changes
Jun 23, 2024
icraggs
added a commit
that referenced
this pull request
Jul 13, 2024
Exporting the -static CMake targets when both shared and static libraries built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When just the static library is built, the CMake targets are properly exported (i.e. xxx-static, like
eclipse-paho-mqtt-c::paho-mqtt3a-static, etc).But when both the shared and static libraries are built, only the shared targets are exported. The static ones are not - but should be.
This fixes the issue so that the
-staticCMake targets are always exported when the static libraries are built.This problem is causing broken builds for the Paho C++ library. See:
eclipse-paho/paho.mqtt.cpp#500