Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced deprecated methods and calls #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaced deprecated methods and calls #194

wants to merge 1 commit into from

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Aug 17, 2024 •
edited
Loading

  • Factory renamed to ServantFactory
    • name based on javadoc
    • Factory caused compilation error because it is a keyword
  • CodegenProxyCreator.create removed
    • deprecated, because it called deprecated PFL methods which did not work on JDK17+
  • IDLLeadingUnderscoresTest - removed test for _() method name
    • Forbidden in JDK21+
    • See JEP 443
  • TestCodegenProxyCreator, Sample
    • using different method than the deprecated one

Merging

@dmatej
Replaced deprecated methods and calls
7ff42f7 
- Factory renamed to ServantFactory
  - name based on javadoc
  - Factory caused compilation error because it is a keyword
- CodegenProxyCreator.create removed
  - deprecated, because it called deprecated PFL methods which did not work on
    JDK17+
- IDLLeadingUnderscoresTest - removed test for _() method name
  - Forbidden in JDK21+
  - See JEP 443
- TestCodegenProxyCreator, Sample
  - using different method than the deprecated one


Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej mentioned this pull request Aug 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmatej @arjantijms