Abandoning JDK8 #61
Draft
Abandoning JDK8 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2024
Draft
Signed-off-by: David Matějček <[email protected]>
- We already use release 11 - Build failed when I tried to use toolchain for 1.8 - Removed code using Unsafe which is not supported on JDK23 any more Signed-off-by: David Matějček <[email protected]>
- However we still build for JDK11. - It would be good to run tests also for other versions Signed-off-by: David Matějček <[email protected]>
- where possible calls were replaced by another method - "standard" code moved from Bridge to BridgeBase - ByteCodeGenerator would need an anchor class, is not used anywhere -> deleted Signed-off-by: David Matějček <[email protected]>
- ORB was removed from JDK11 Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- By default, Felix changes - to a . (dot) - Fix for snapshot: Version included snapshot, that breaks usages - sun packages in pfl-basic are not optional, sorry, you use Unsafe. - I don't see the reason to run Felix install+deploy in pfl-basic Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregated PR of those previous - should be rebased after their merge.
Tested with GlassFish 8 tests locally on JDK21 and 23.
Partially resolves #43 , however there are still some usages of methods which still do exist in 23. We can probably continue in next PRs but here I need something usable for GlassFish.