Fixes coalesce and case operators in multithreaded environments with different number of arguments #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different number of arguments The bug is described in the issue eclipse-ee4j#2136 TestArgumentListFunctionExpressionConcurrency.java - adds tests that reproduce the bug. ArgumentListFunctionExpression.java - fixes printSQL to use the operator itself and not the common instance of it
lukasj
approved these changes
Sep 11, 2024
rfelcman
reviewed
Sep 11, 2024
| @@ -97,11 +97,10 @@ public void setOperator(ExpressionOperator theOperator) { | |||
| */ | |||
| @Override | |||
| public void printSQL(ExpressionSQLPrinter printer) { | |||
| ListExpressionOperator realOperator; | |||
| realOperator = (ListExpressionOperator)getPlatformOperator(printer.getPlatform()); | |||
There was a problem hiding this comment.
Sorry but this removal is problematic as there should be some differences between DB platforms.
Try e.g. mvn clean verify -pl :org.eclipse.persistence.jpa.jse.test -P derby against before modification and after to see what happens. -P derby means that Implicit Apache Derby DB is used (it is managed started/stopped by EclipseLink Maven build scripts).
There was a problem hiding this comment.
Ok, I see what you mean.
In that case the problem is that getPlatformOperator() returns the same cached instance of the operator on each call which leads to errors with the operators with variable number of arguments like "coalesce" and "case when".
I think I have a solution in mind. I will push it later.
…different number of arguments The bug is described in the issue eclipse-ee4j#2136 TestArgumentListFunctionExpressionConcurrency.java - adds tests that reproduce the bug. ExpressionOperator.java - fixes getArgumentIndices by disabling the caching of the dynamically created argument indexes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is described in the issue #2136. The bug was in the 2.7 version, and it was somewhat fixed in later versions but still failed when statements had different number of parameters.
TestArgumentListFunctionExpressionConcurrency.java - adds tests that reproduce the bug.
ExpressionOperator.java - fixes getArgumentIndices by disabling the caching of the dynamically created argument indexes.