enhance Helm chart to configure Ditto services via ConfigMap #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kalinkostashki could you have a look, please? |
thjaeckle
force-pushed
the
helm/config-via-configmap
branch
from
af37e35
to
3e82718
Compare
* instead of configuring via System Properties
thjaeckle
force-pushed
the
helm/config-via-configmap
branch
from
3e82718
to
b8b06ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, configuration of very dynamic settings (like e.g. custom metrics or entity creation) is done via SystemProperties in the Helm chart.
This can lead to some issues - e.g. if the command line arguments get too long,
trivy, the wrapper process for starting the JVM can no longer handle those.Or another problem is that the Kubernetes "Pods" HTTP API will return all environment variables and all system-properties as part of its response when querying for other Ditto pods during bootstrapping a cluster.
Moving the very dynamic configuration to config files (mounted via ConfigMaps) is an elegant solution for that.