Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report to coveralls only if integration tests passed #963

Merged

Conversation

mkemel
Copy link
Member

@mkemel mkemel commented Oct 16, 2024

The coverage report makes sense only when all tests passed. When a test fails - the pipeline tries to report to coveralls, but as long as tests are not fixed - this is not something of interest, and it creates just an additional failure.

The coverage report makes sense only when all tests passed.
When a test fails - the pipeline tries to report to coveralls,
but as long as tests are not fixed - this is not something of
interest, and it creates just an additional failure.

Signed-off-by: Mark Kemel <[email protected]>
@mkemel mkemel marked this pull request as ready for review October 16, 2024 08:09
@mwperina
Copy link
Member

/packit retest-failed

@coveralls
Copy link

Coverage Status

coverage: 83.413% (+0.1%) from 83.286%
when pulling 099e847 on mkemel:do-not-run-coveralls-when-failed
into 0e8c2df on eclipse-bluechi:main.

@mwperina
Copy link
Member

/packit retest-failed

1 similar comment
@mwperina
Copy link
Member

/packit retest-failed

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member

/packit retest-failed

1 similar comment
@mwperina
Copy link
Member

/packit retest-failed

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi
Copy link
Member

engelmi commented Oct 18, 2024

/packit retest-failed

@engelmi
Copy link
Member

engelmi commented Oct 18, 2024

/packit retest-failed --label standard

@mwperina mwperina merged commit 164afb1 into eclipse-bluechi:main Oct 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants