Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KillUnit API #939

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Sep 11, 2024

Fixes: #938

The KillUnit API has been implemented, forwarding the API call to systemd. For bluechictl, the command kill has been implemented to mirror the systemctl kill command - including the command options. It also added integration tests for the new KillUnit functionality.

@coveralls
Copy link

coveralls commented Sep 11, 2024

Coverage Status

coverage: 85.196% (-0.3%) from 85.492%
when pulling d396575 on engelmi:add-kill-unit-api
into 0dba297 on eclipse-bluechi:main.

@engelmi engelmi force-pushed the add-kill-unit-api branch 2 times, most recently from a8df3e1 to c8efd0f Compare September 11, 2024 15:56
data/org.eclipse.bluechi.Node.xml Outdated Show resolved Hide resolved
src/bindings/python/bluechi/api.py Outdated Show resolved Hide resolved
@engelmi engelmi force-pushed the add-kill-unit-api branch 2 times, most recently from b66d1f2 to ce5856f Compare September 12, 2024 06:59
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the first method-specific usage

src/client/method-kill.c Outdated Show resolved Hide resolved
Fixes: eclipse-bluechi#938

The KillUnit API has been implemented, forwarding the API
call to systemd. For bluechictl, the command kill has been
implemented to mirror the systemctl kill command - including
the command options. It also added integration tests for the
new KillUnit functionality.

Signed-off-by: Michael Engel <[email protected]>
@engelmi
Copy link
Member Author

engelmi commented Sep 12, 2024

/packit test

@engelmi engelmi merged commit 3e8a433 into eclipse-bluechi:main Sep 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Add KillUnit API
4 participants